Tracing v1.0#2611
Conversation
IlaHadiAssar
force-pushed
the
feature/tracing/v1.0
branch
from
06bd0d6 to
4185965
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| std::shared_ptr<Logging::CLogProvider> g_log_provider_instance; | ||
| std::shared_ptr<Logging::CLogReceiver> g_log_receiver_instance; | ||
|
|
||
| std::shared_ptr<tracing::TraceProvider> g_trace_provider_instance; |
There was a problem hiding this comment.
warning: variable 'g_trace_provider_instance' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
std::shared_ptr<tracing::TraceProvider> g_trace_provider_instance;
^| constexpr size_t kDefaultTracingBatchSize = 10; | ||
|
|
||
| // Specifies the type of operation being traced | ||
| enum operation_type |
There was a problem hiding this comment.
warning: enum 'operation_type' uses a larger base type ('unsigned int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size]
enum operation_type
^| }; | ||
|
|
||
| // Specifies the direction of the topic (publisher or subscriber) | ||
| enum topic_direction |
There was a problem hiding this comment.
warning: enum 'topic_direction' uses a larger base type ('unsigned int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size]
enum topic_direction
^|
|
||
| // Bitmask enum for active transport layers used in tracing spans. | ||
| // These use power-of-two values so combinations can be expressed with bitwise OR. | ||
| enum eTracingLayerType : uint64_t |
There was a problem hiding this comment.
warning: enum 'eTracingLayerType' uses a larger base type ('uint64_t' (aka 'unsigned long'), size: 8 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size]
enum eTracingLayerType : uint64_t
^| { | ||
|
|
||
| // Interface for tracing writers. | ||
| class TracingWriter |
There was a problem hiding this comment.
warning: class 'TracingWriter' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
class TracingWriter
^
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This reverts commit f86eb6f.
|
|
||
| bool CPublisher::Send(CPayloadWriter& payload_, long long time_) | ||
| { | ||
| { |
There was a problem hiding this comment.
Leave this file untouched, this is not necessary for this PR
| @@ -0,0 +1,68 @@ | |||
| /* ========================= eCAL LICENSE ================================= | |||
| * | |||
| * Copyright (C) 2016 - 2025 Continental Corporation | |||
There was a problem hiding this comment.
Use the proper Aumovio copyright header
| @@ -0,0 +1,75 @@ | |||
| /* ========================= eCAL LICENSE ================================= | |||
| * | |||
| * Copyright (C) 2016 - 2025 Continental Corporation | |||
There was a problem hiding this comment.
Use the proper Aumovio copyright header
| @@ -0,0 +1,39 @@ | |||
| /* ========================= eCAL LICENSE ================================= | |||
| * | |||
| * Copyright (C) 2016 - 2025 Continental Corporation | |||
| @@ -0,0 +1,51 @@ | |||
| /* ========================= eCAL LICENSE ================================= | |||
| * | |||
| * Copyright (C) 2016 - 2025 Continental Corporation | |||
|
|
||
| namespace eCAL | ||
| { | ||
| namespace tracing |
There was a problem hiding this comment.
style and 2 spaces for indentation instead of 4
|
|
||
| // record topic metadata for tracing | ||
| { | ||
| eCAL::tracing::STopicMetadata meta; |
There was a problem hiding this comment.
Maybe assign this meta data only when there is a g_trace_provider, and take only the scope from the if-statement below
|
|
||
| // record topic metadata for tracing | ||
| { | ||
| eCAL::tracing::STopicMetadata meta; |
|
|
||
| namespace eCAL | ||
| { | ||
| namespace tracing |
|
|
||
| namespace eCAL | ||
| { | ||
| namespace tracing |
4 participants
This branch superseds the tracing poc